Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20553] Fix nightly jobs #4525

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[20553] Fix nightly jobs #4525

merged 1 commit into from
Mar 7, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 7, 2024

Description

In the PR improving the CI...

... a matrix of Fast DDS branches (supported versions) was introduced in the nightly jobs.
That introduced the fail-fast strategy default value (true) which makes nightly jobs fail if any of then fails.
This PR modifies that behaviour in favor of the intended behavior: run ALL nightlys independently.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Mar 7, 2024
@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Mar 7, 2024
@JesusPoderoso JesusPoderoso self-assigned this Mar 7, 2024
@EduPonz EduPonz merged commit 5c87d9d into master Mar 7, 2024
8 checks passed
@EduPonz EduPonz deleted the hotfix/nightly_jobs branch March 7, 2024 20:01
@EduPonz EduPonz modified the milestones: v2.14.1, v2.14.0 - Frozen Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants