[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

JesusPoderoso · 2024-03-25T15:26:41Z

Description

This PR forces the ResourceLimitsQoS values (max_samples, max_instances and max_samples_per_instance) to be considered as unlimited if a value greater than zero is NOT provided.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Fixes #4609

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [20722] Update docs to force unlimited ResourceLimits if lower or equal to zero Fast-DDS-docs#738
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

src/cpp/fastdds/publisher/DataWriterHistory.cpp

src/cpp/fastrtps_deprecated/publisher/PublisherHistory.cpp

test/mock/rtps/PublisherHistory/fastdds/publisher/DataWriterHistory.hpp

test/mock/rtps/PublisherHistory/fastrtps/publisher/PublisherHistory.h

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

EduPonz

I think we need a test for creating the entities with negative values for resource limits

EduPonz · 2024-04-03T05:28:45Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-04-03T05:28:59Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4652 [20722] Force unlimited ResourceLimits if lower or equal to zero (backport #4617) has been created for branch 2.13.x
#4653 [20722] Force unlimited ResourceLimits if lower or equal to zero (backport #4617) has been created for branch 2.10.x
#4654 [20722] Force unlimited ResourceLimits if lower or equal to zero (backport #4617) has been created for branch 2.6.x but encountered conflicts

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

EduPonz · 2024-04-03T06:13:15Z

@richiprosima please test this

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso · 2024-04-03T08:31:52Z

@richiprosima please test this

* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Include check in previous tests Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Fix test typo Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 31b8ad1) # Conflicts: # include/fastdds/dds/core/policy/QosPolicies.hpp # test/unittest/dds/publisher/DataWriterTests.cpp # test/unittest/dds/subscriber/DataReaderTests.cpp # test/unittest/dds/topic/TopicTests.cpp

* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Include check in previous tests Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Fix test typo Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 31b8ad1)

* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Include check in previous tests Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20722: Fix test typo Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 31b8ad1) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

8d7fb2a

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso added this to the v2.14.1 milestone Mar 25, 2024

JesusPoderoso self-assigned this Mar 25, 2024

JesusPoderoso added the needs-review PR that is ready to be reviewed label Mar 25, 2024

JesusPoderoso requested a review from a team March 25, 2024 15:59

github-actions bot added the ci-pending PR which CI is running label Mar 25, 2024

JesusPoderoso removed the request for review from a team March 25, 2024 16:00

EduPonz changed the title ~~[20638] Force unlimited ResourceLimits if lower or equal to zero~~ [20722] Force unlimited ResourceLimits if lower or equal to zero Apr 2, 2024

EduPonz suggested changes Apr 2, 2024

View reviewed changes

JesusPoderoso mentioned this pull request Apr 2, 2024

[20722] Update docs to force unlimited ResourceLimits if lower or equal to zero eProsima/Fast-DDS-docs#738

Merged

7 tasks

Refs #20722: Apply rev suggestions

1d82d1f

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso requested a review from EduPonz April 2, 2024 21:32

EduPonz suggested changes Apr 3, 2024

View reviewed changes

Refs #20722: Include check in previous tests

81742d8

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso force-pushed the hotfix/4609 branch from 2207986 to 81742d8 Compare April 3, 2024 05:51

JesusPoderoso requested a review from EduPonz April 3, 2024 05:56

EduPonz previously approved these changes Apr 3, 2024

View reviewed changes

EduPonz removed the needs-review PR that is ready to be reviewed label Apr 3, 2024

Refs #20722: Fix test typo

16eff5b

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso dismissed EduPonz’s stale review via 16eff5b April 3, 2024 08:31

JesusPoderoso requested a review from EduPonz April 3, 2024 08:31

EduPonz approved these changes Apr 3, 2024

View reviewed changes

EduPonz merged commit 31b8ad1 into master Apr 4, 2024
11 of 16 checks passed

EduPonz deleted the hotfix/4609 branch April 4, 2024 10:40

EduPonz removed the ci-pending PR which CI is running label Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

JesusPoderoso commented Mar 25, 2024 •

edited

Loading

EduPonz left a comment

EduPonz commented Apr 3, 2024

mergify bot commented Apr 3, 2024 •

edited

Loading

EduPonz commented Apr 3, 2024

JesusPoderoso commented Apr 3, 2024

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

Conversation

JesusPoderoso commented Mar 25, 2024 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz left a comment

Choose a reason for hiding this comment

EduPonz commented Apr 3, 2024

mergify bot commented Apr 3, 2024 • edited Loading

✅ Backports have been created

EduPonz commented Apr 3, 2024

JesusPoderoso commented Apr 3, 2024

JesusPoderoso commented Mar 25, 2024 •

edited

Loading

mergify bot commented Apr 3, 2024 •

edited

Loading