[20652] Improve filtering of DNS tests (backport #4603) #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #20652. Fix windows command to check local DNS name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Correctly combine blackbox filters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Informational message on participant test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Use correct command on Apple to check local DNS name. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Use filter on RTPS blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Fix typo. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Fix filter in LocatorTests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Filter with grep in mac. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Fix concurrency group in ubuntu-ci. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 1d9d559)
9 tasks
|
@richiprosima please test this |
|
CI issues unrelated to the PR. |
JesusPoderoso
added
ready-to-merge
EduPonz
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When both PKCS#11 and DNS tests had to be disabled, the filter expression for gtest was incorrectly generated.
This made Ubuntu and MacOS CI on github fail.
Additionally, this PR fixes the commands used to detect whether the DNS local entries for the corresponding tests have been added, and adds some related informational messages to the CMake files.
@Mergifyio backport 2.13.x
Contributor Checklist
Commit messages follow the project guidelines.
N/A The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4603 done by [Mergify](https://mergify.com).