-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of decf689 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
10 tasks
@EduPonz would you mind addressing the conflicts here ? |
* Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit decf689)
EduPonz
force-pushed
the
mergify/bp/2.6.x/pr-4628
branch
from
April 4, 2024 12:55
32c9bb5
to
b30c4c3
Compare
Mario-DL
added
ci-pending
PR which CI is running
and removed
conflicts
Backport PR wich git cherry pick failed
labels
Apr 4, 2024
As this PR in only modifying the docs workflow, I won`t trigger jenkins ci |
Mario-DL
approved these changes
Apr 8, 2024
Mario-DL
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Apr 8, 2024
MiguelCompany
pushed a commit
that referenced
this pull request
May 21, 2024
…#4644) * Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit decf689) Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
May 21, 2024
* Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit decf689) Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
May 21, 2024
…#4643) * Refs #20694: Use ci.repos to get gtest * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch * Refs #20694: Get deduced branch output correctly * Refs #20694: Use CMake 3.22.6 * Refs #20694: Pin get_related_branch_from_repo action version to v0 --------- (cherry picked from commit decf689) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
ubuntu-build-and-test-documentation
Github CI job to include Fast DDS Python in the build.It also uses a new action from eProsima-CI to deduce which branch to use:
TODO:
get_related_branch_from_repo
once eProsima-CI releases the new action@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4628 done by [Mergify](https://mergify.com).