-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20701] Enforce SHM ports open mode exclusions (backport #4635) #4647
Conversation
* Refs #20701. Added unit regression tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20701. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20701. Fix issue. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 3d159dc) # Conflicts: # test/blackbox/common/BlackboxTestsTransportSHM.cpp
Cherry-pick of 3d159dc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@MiguelCompany would you mind addressing the conflicts here ? |
@MiguelCompany Friendly ping here |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima please test this |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Internally agree to close this PR |
Description
As originally reported in #4504 a port could be open first with ReadShared and then with ReadExclusive the internal state of the port was incorrectly changed. This meant that the same port could be used at the same time for unicast and multicast.
This PR fixes #4634 by checking incompatibilities inside
lock_read_exlcusive
/lock_read_shared
methods of the Port class.@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4635 done by [Mergify](https://mergify.com).