Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20653] Increase sleep to miss the deadline in macOS flaky tests (backport #4636) #4679

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 10, 2024

Description

This PR increases the sleep between samples sent to miss the deadline in ownership flaky tests " exclusive_kind_non_keyed_reliable_deadline"

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4636 done by [Mergify](https://mergify.com).

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 421bdb2)
@EduPonz EduPonz added this to the v2.13.5 milestone Apr 10, 2024
@JesusPoderoso JesusPoderoso self-requested a review April 10, 2024 05:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 10, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

3 similar comments
@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@JesusPoderoso
Copy link
Contributor

CI issues are unrelated to the PR.
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 18, 2024
@EduPonz EduPonz merged commit 122dbf8 into 2.13.x Apr 18, 2024
3 of 12 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4636 branch April 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants