Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20650] Examples refactor: Delivery mechanisms #4836

Closed

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 23, 2024

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.

In this delivery mechanisms example, the key changes are:

  • loans and data-sharing compatible: bounded types, final extensibility.
  • use loans mechanism for data management
  • add an option to select all delivery mechanisms

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone May 23, 2024
@github-actions github-actions bot added ci-pending PR which CI is running labels May 23, 2024
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from e8894d6 to 8dee301 Compare May 23, 2024 14:17
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 23, 2024 14:18
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 8dee301 to 1e2d3d0 Compare May 23, 2024 14:23
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 23, 2024 14:23
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 1e2d3d0 to 365e649 Compare May 24, 2024 07:33
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 24, 2024 07:33
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label May 24, 2024
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 24, 2024 17:04
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 6126fa8 to 31e1a55 Compare May 27, 2024 06:06
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 27, 2024 06:06
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 31e1a55 to 608380b Compare May 27, 2024 13:16
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf May 27, 2024 13:16
Copy link
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some tests, we found out that there is an issue when setting the domain in the PubSub participant and the writer and the reader try to communicate through UDP. A deeper investigation is required.

examples/cpp/delivery_mechanisms/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/delivery_mechanisms/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/delivery_mechanisms/PubSubApp.cpp Outdated Show resolved Hide resolved
examples/cpp/delivery_mechanisms/SubscriberApp.cpp Outdated Show resolved Hide resolved
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label May 30, 2024
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 608380b to b039789 Compare June 6, 2024 13:17
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from b039789 to 217c436 Compare June 10, 2024 09:42
@JesusPoderoso JesusPoderoso changed the base branch from master to hotfix/21162 June 10, 2024 09:42
@JesusPoderoso JesusPoderoso removed the request for review from elianalf June 10, 2024 09:43

switch (config.delivery_mechanism)
{
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS: // (It should never reach this section
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS: // (It should never reach this section
case CLIParser::DeliveryMechanismKind::INTRA_PROCESS:

@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 4fc610f to 5669527 Compare June 12, 2024 11:15
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 12, 2024 11:15
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 2763008 to 782569b Compare June 13, 2024 10:08
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 13, 2024 10:09
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch 2 times, most recently from 5ea03b3 to 6e73700 Compare June 14, 2024 11:01
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 14, 2024 11:02
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 6e73700 to 4434cb0 Compare June 17, 2024 07:42
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 17, 2024 07:43
@JesusPoderoso JesusPoderoso deleted the feature/example_refactor/delivery_mechanism branch June 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants