-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21096] Feature: use PID_DOMAIN_ID during PDP #4888
Conversation
@richiprosima please test_3 discovery-server |
1 similar comment
@richiprosima please test_3 discovery-server |
src/cpp/rtps/builtin/discovery/participant/PDPClientListener.hpp
Outdated
Show resolved
Hide resolved
c14badd
to
e2a35ff
Compare
@richiprosima please test_3 discovery-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI too. I think the only thing left here is to add this to the versions.md file (remember to update the PR checklist)
@richiprosima please test_3 discovery-server |
@richiprosima please test_3 discovery-server |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…t_transport Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…itiator DS listener Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…mains Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Description
This PR adds the
PID_DOMAIN_ID
parameter to the PDP discovery phase with the following considerations:PID_DOMAIN_ID
is always sent.PDPSimple
, domains have either to be the same or not be defined in the remote incomingParticipantProxyData
.Discovery Server
we do not check the parameter since it is meant to operate across domains.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist