-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21121] IPayloadPool refactor #4892
Conversation
Since the |
0588ba0
to
195b875
Compare
src/cpp/fastdds/subscriber/DataReaderImpl/SampleLoanManager.hpp
Outdated
Show resolved
Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl/SampleLoanManager.hpp
Outdated
Show resolved
Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl/SampleLoanManager.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
0928c99
to
e023500
Compare
0c8fb40
to
0edef49
Compare
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
2e8424b
to
432b2ba
Compare
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
432b2ba
to
e383089
Compare
@richiprosima Please test_3 discovery-server |
Checked locally that discovery server tests pass with this and #4932. Ready to merge. |
@richiprosima Please test_3 discovery-server because #4932 has just been merged |
@richiprosima Please test_3 discovery-server with updated ci branch |
@richiprosima Please test_3 discovery-server because I made a mistake in the jenkins job configuration |
Description
This PR adds two main changes:
payload_owner_
fromCacheChange_t
toSerializedPayload_t
IPayloadPool
class and all derived classes to only manageSerializedPayload_t
, instead ofCacheChange_t
get_payload()
methods refactorSerializedPayload_t
copies are forbiddenIn this way, the
payload_owner_
is no longer related to a cache change, but to the payload it refers.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist