-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21129] Migrate fastrtps namespace to fastdds #4898
Conversation
7f89bd2
to
8333472
Compare
5590928
to
19234a4
Compare
19234a4
to
3a0ce6d
Compare
3e559b4
to
0053c97
Compare
86de509
to
a14d4b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- StatisticsCommon.hpp has a
fastrtps
reference - StatisticsBase.hpp has a
fastrtps
reference - utils includes have a guard with
FASTRTPS
- We can remove the
XFAIL_FASTRTPS_TESTS
in xfail_tests.cmake - Remove
fastdds::
from all headers in include. It is not needed - Remove
fastdds::
from all src files. It is not needed almost anywhere - Almost all
using fastdds::
that are notusing fastdds::rtps
are not needed anymore. Same happens withusing eprosima::fastdds::
outside of the examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid the following are not yet addressed in full:
- Remove
fastdds::
from all headers in include. It is not needed - Remove
fastdds::
from all src files. It is not needed almost anywhere - Almost all
using fastdds::
that are not using fastdds::rtps are not needed anymore. - Same happens with
using eprosima::fastdds::
outside of the examples
8aa916e
to
a151857
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
a151857
to
4b8c06d
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
4b8c06d
to
28ba6ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with green CI
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@richiprosima please test_3 discovery-server |
Description
This PR migrates all the fastrtps namespace to fastdds. It also removes all the unnecessary nested namespace and using namespace.
Related PR:
Fast DDS Python: eProsima/Fast-DDS-python#135
Shapes Demo: eProsima/ShapesDemo#141
Fast DDS GEN: eProsima/Fast-DDS-Gen#350
Discovery Server: eProsima/Discovery-Server#87
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [21129] Migrate fastrtps namespace Fast-DDS-docs#813
Reviewer Checklist