Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20953] Fix Proxy block in TypeLookup Service #4901

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 6, 2024

Description

This PR fixes two minor data races and solves a bugfix in which the Proxy Pool was running out of Proxies due multiple requests of the TypeLookup Service. Now, if the type is not known, a copy of the Proxy is made to avoid blocking the discovery.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label Jun 6, 2024
@cferreiragonz cferreiragonz added this to the v3.0.0 milestone Jun 6, 2024
@richiware richiware self-requested a review June 10, 2024 06:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 10, 2024
@cferreiragonz cferreiragonz removed the needs-review PR that is ready to be reviewed label Jun 10, 2024
@cferreiragonz
Copy link
Contributor Author

@richiprosima please test this

@richiware richiware added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 10, 2024
@cferreiragonz
Copy link
Contributor Author

@richiprosima please test_3 this

@richiware richiware merged commit 8c89074 into master Jun 10, 2024
10 of 18 checks passed
@richiware richiware deleted the bugfix/proxies_tlus branch June 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants