Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20816] Properly delete builtin statistics writers upon delete_contained_entities() (backport #4891) #4916

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[20816] Properly delete builtin statistics writers upon delete_contained_entities() (backport #4891) #4916

merged 2 commits into from
Sep 18, 2024

Commits on Sep 12, 2024

  1. Properly delete builtin statistics writers upon `delete_contained_ent… 

    …ities()` (#4891)

* Refs #20816: Add BB test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20816: Fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20816: Apply Edu's suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 0d62335)

# Conflicts:
#	src/cpp/statistics/fastdds/domain/DomainParticipantImpl.cpp
    @Mario-DL @MiguelCompany
    Mario-DL authored and MiguelCompany committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3ce98b8 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts. 

    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    874b844 View commit details
    Browse the repository at this point in the history