Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21131] Make Blackbox tests not include any private API #4953

Merged
merged 14 commits into from
Jun 25, 2024
Merged

[21131] Make Blackbox tests not include any private API #4953

merged 14 commits into from
Jun 25, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jun 17, 2024 •
edited by elianalf
Loading

Description

This PR removes private API from Blackbox tests. Essentially, any include within <rtps/

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jun 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 17, 2024
@Mario-DL Mario-DL force-pushed the feature/21131 branch 3 times, most recently from 901e113 to 3fb8508 Compare June 18, 2024 07:44
@Mario-DL Mario-DL requested review from elianalf and removed request for richiprosima and elianalf June 18, 2024 07:44
elianalf
elianalf suggested changes Jun 19, 2024
View reviewed changes
include/fastdds/rtps/transport/test_UDPv4TransportDescriptor.h Outdated Show resolved Hide resolved
include/fastdds/rtps/transport/test_UDPv4TransportDescriptor.h Outdated Show resolved Hide resolved
test/blackbox/types/rtps/core_types.idl Outdated Show resolved Hide resolved
utils/scripts/update_generated_code_from_idl.sh Outdated Show resolved Hide resolved
test/blackbox/common/BlackboxTestsPubSubHistory.cpp Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDiscovery.cpp Outdated Show resolved Hide resolved
versions.md Show resolved Hide resolved
@Mario-DL Mario-DL requested a review from elianalf June 20, 2024 06:32
@Mario-DL Mario-DL requested review from elianalf and removed request for elianalf June 20, 2024 06:57
@Mario-DL Mario-DL mentioned this pull request Jun 21, 2024
Merged
7 tasks
elianalf
elianalf previously approved these changes Jun 21, 2024
View reviewed changes
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 21, 2024
@Mario-DL Mario-DL requested a review from elianalf June 21, 2024 11:21
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 21, 2024
@Mario-DL Mario-DL requested review from elianalf and removed request for elianalf June 23, 2024 18:21
@Mario-DL
Refs #21131: Make test_SHMTransportDescriptor public
1ead663 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Add TestTransportOptions to test_UDPv4 transport descriptor
db2b006 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Add core_types.idl for HeartBeat & AckNack submessages d…
051a412 
…efinition

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update generated code updater
176e378 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Add filter_helpers for cdr_parse* functions
6516f5c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update BB tests CMakeLists.txt
72375c7 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update BlackboxTests*
15004c7 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update DDSBlackboxTests*
832997c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update RTPSStatisticsTests
74d6741 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Update versions.md
fd5c409 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Linter
cd9d6df 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Apply Eliana's rev
63d3e86 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Fix docs spelling: remove doxygen reference to SharedMem…
b1267fa 
…TransportDescriptor as it is redundant

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21131: Regenerate core_types
a5553be 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from elianalf and removed request for elianalf June 24, 2024 12:36
@elianalf elianalf removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jun 24, 2024
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jun 25, 2024
@EduPonz EduPonz merged commit 1261417 into master Jun 25, 2024
14 of 17 checks passed
@EduPonz EduPonz deleted the feature/21131 branch June 25, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @elianalf @EduPonz