Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21198] Add product version on Participant Discovery information #4964

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 18, 2024

Description

This PR introduces a new custom pid PID_PRODUCT_VERSION (0x8000) used to send the Fast DDS version.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Add product version on Participant Discovery information Add product version on Participant Discovery information [21198] Jun 18, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jun 21, 2024
@rsanchez15 rsanchez15 changed the title Add product version on Participant Discovery information [21198] [21198] Add product version on Participant Discovery information Jul 22, 2024
@richiware richiware added ci-pending PR which CI is running and removed needs rebase labels Jul 24, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/21197 branch 2 times, most recently from b033664 to 9f15e5a Compare July 26, 2024 10:04
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 23d467f into master Jul 29, 2024
16 of 17 checks passed
@richiware richiware deleted the feature/21197 branch July 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants