[20628] Create InitialConnection for TCP initial peers 2.13 & 2.10 & 2.6 (backport #4947) #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
10 tasks
JesusPoderoso
previously approved these changes
Jun 27, 2024
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
edd8247
to
351fb55
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
351fb55
to
1502a0e
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
|
The new test is failing on Windows. Could you take a look @cferreiragonz? |
MiguelCompany
changed the title
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
1502a0e
to
e4ef4d2
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
e4ef4d2
to
2461b5c
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
cferreiragonz
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
25a48f5
to
02c283e
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
|
@Mergifyio rebase |
* Refs #20650: Add test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20650: Create initial connect for initial peers Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit a0a4fee)
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4947
branch
from
02c283e
to
533396c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the features introduced in #4584 to ALWAYS create a connection channel for the TCP when initial peers are configured.
@Mergifyio backport 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4947 done by [Mergify](https://mergify.com).