-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21364] Remove double // in some installation paths (backport #5111) #5129
Conversation
Cherry-pick of 8c477dc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@Mergifyio backport 2.10.x |
✅ Backports have been created
|
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 8c477dc) # Conflicts: # CMakeLists.txt
8cfca68
to
6e52e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
CI issues are unrelated to the PR. |
Description
Some installation paths contained a
//
, this PR fixes those, even though they are not harmful.@Mergifyio backport 2.14.x
IMPORTANT: Same change needs to be backported to 2.10.x, but it'd be easier from the 2.14.x PR.
Contributor Checklist
Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A: Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5111 done by [Mergify](https://mergify.com).