-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21638] Be less strict with parameter lengths (backport #5225) #5247
Open
mergify
wants to merge
2
commits into
2.14.x
Choose a base branch
from
mergify/bp/2.14.x/pr-5225
base: 2.14.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp
Cherry-pick of 7b111f9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interoperability checks with Intercom DDS surfaced an issue in the deserializer for builtin topics.
The deserializer expects the parameters in the parameter list to be exactly the expected length.
Debug showed that Intercom DDS is sending a reliability parameter longer than expected, and their DATA(r) and DATA(w) messages were discarded due to a deserialization error.
This PR:
@Mergifyio backport 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5225 done by [Mergify](https://mergify.com).