Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21696] Fix Secure Discovery Server client disposals guid and handshake_handle assertion #5257

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 24, 2024

Description

This PR addresses two issues regarding Secure Discovery Server

  • Disposal guid was not beaing properly send from clients to server.
  • Prevents an assertion triggering in the SecurityManager as a consequence of not being able to retrieve a new change in the participant_stateless_msg_writer

@Mergifyio backport 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.14.4 milestone Sep 24, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL marked this pull request as ready for review October 16, 2024 11:24
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 16, 2024 11:24
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 16, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from JesusPoderoso and removed request for JesusPoderoso October 17, 2024 12:59
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a NIT

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp Outdated Show resolved Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany MiguelCompany merged commit 5ceebe0 into 2.14.x Oct 31, 2024
3 checks passed
@MiguelCompany MiguelCompany deleted the fix/21696 branch October 31, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants