-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21773] Fix DynamicData union deserialization when no member is selected #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanlofer-eprosima
changed the title
Fix DynamicData union deserialization when no member is selected
[21773] Fix DynamicData union deserialization when no member is selected
Sep 30, 2024
5 tasks
juanlofer-eprosima
force-pushed
the
hotfix/unions-without-default
branch
from
October 1, 2024 05:41
d1e90f3
to
1fa1011
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
…selected Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
hotfix/unions-without-default
branch
from
October 1, 2024 06:39
1fa1011
to
37d419a
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
requested review from
richiware
and removed request for
richiware
October 1, 2024 12:33
richiware
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dds-types-test
PR was merged. Please, update the thirdparty in this PR.
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
hotfix/unions-without-default
branch
from
October 2, 2024 07:38
bb40b7a
to
d85baf4
Compare
richiware
approved these changes
Oct 2, 2024
richiware
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix DynamicData union deserialization when no member is selected. This PR also fixes DynamicData to json serialization for this scenario, and comparisson between two DynamicDatas with this type.
Merge after:
@Mergifyio backport 3.0.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist