[22022] Fix assertion deleting a Datawriter configured with persistent and flow controller

[richiware]

Description

An assertion is launched when a Datawriter is destroyed and it was configured with persistence and flow controller.

BlackboxTests_DDS_PIM: ../../../../eprosima/fastdds/src/cpp/rtps/flowcontrol/FlowControllerImpl.hpp:792: void eprosima::fastdds::rtps::FlowControllerPriorityWithReservationSchedule::unregister_writer(eprosima::fastdds::rtps::BaseWriter*): Assertion `it != writers_queue_.end()' failed.

This PR fixes it.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• N/A Any new/modified methods have been properly documented using Doxygen.
• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A New feature has been added to the versions.md file (if applicable).
• N/A New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[MiguelCompany]

LGTM with green CI