Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21293] Fix destruction data-race on participant removal in intra-process (backport #5034) #5367

Open
wants to merge 4 commits into
base: 2.14.x
Choose a base branch
from

Commits on Oct 29, 2024

  1. Fix destruction data-race on participant removal in intra-process (#5034

    )
    
    * Refs #21293: Add BB test
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Reinforce test to fail more frequently
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Add RefCountedPointer.hpp to utils
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Add unittests for RefCountedPointer
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: LocalReaderPointer.hpp
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: BaseReader aggregates LocalReaderPointer
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: ReaderLocator aggregates LocalReaderPointer
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: RTPSDomainImpl::find_local_reader returns a sared_ptr<LocalReaderPointer> and properly calls local_actions_on_reader_removed()
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: RTPSWriters properly using LocalReaderPointer::Instance when accessing local reader
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Linter
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Fix windows warnings
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Address Miguel's review
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: Apply last comment
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    * Refs #21293: NIT
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    
    ---------
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    (cherry picked from commit 456e45f)
    
    # Conflicts:
    #	include/fastdds/rtps/writer/ReaderLocator.h
    #	include/fastdds/rtps/writer/ReaderProxy.h
    #	src/cpp/rtps/RTPSDomain.cpp
    #	src/cpp/rtps/RTPSDomainImpl.hpp
    #	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
    #	src/cpp/rtps/participant/RTPSParticipantImpl.h
    #	src/cpp/rtps/reader/BaseReader.cpp
    #	src/cpp/rtps/reader/BaseReader.hpp
    #	src/cpp/rtps/writer/ReaderLocator.cpp
    #	src/cpp/rtps/writer/StatefulWriter.cpp
    #	src/cpp/rtps/writer/StatelessWriter.cpp
    #	test/blackbox/common/DDSBlackboxTestsBasic.cpp
    #	test/mock/rtps/ReaderLocator/fastdds/rtps/writer/ReaderLocator.h
    #	test/unittest/utils/CMakeLists.txt
    Mario-DL authored and mergify[bot] committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7dbf4bd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Solve conflicts

    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    Mario-DL committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8560483 View commit details
    Browse the repository at this point in the history
  2. Apply Miguel's suggestions: make LocalReaderPointer inherit RefCounte…

    …rPointer<> and add DOXYGEN_SHOULD_SKIP_THIS_PUBLIC
    
    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    Mario-DL committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e837ad7 View commit details
    Browse the repository at this point in the history
  3. Apply NIT

    Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
    Mario-DL committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e2c4e5e View commit details
    Browse the repository at this point in the history