Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21696] Fix SecurityManager assertion in Secure DS (backport #5329) #5369

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 30, 2024

Description

This PR addresses an assertion triggering in the SecurityManager as a consequence of not being able to retrieve a new change for the participant_stateless_msg_writer

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • Any new/modified methods have been properly documented using Doxygen.

  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5329 done by [Mergify](https://mergify.com).

* Refs #21696: Add regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21696: Add fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit ce72a14)
@MiguelCompany MiguelCompany added this to the v3.1.1 milestone Oct 31, 2024
@MiguelCompany MiguelCompany self-requested a review October 31, 2024 15:10
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 31, 2024
@MiguelCompany MiguelCompany merged commit 6837c32 into 3.1.x Nov 14, 2024
17 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-5329 branch November 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants