Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22054] Address XMLDynamicParser regression #5383

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 5, 2024

Description

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.2.0 milestone Nov 5, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 5, 2024 09:53
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 5, 2024
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x

Copy link
Contributor

mergify bot commented Nov 6, 2024

backport 3.1.x 3.0.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit fe29535 into master Nov 6, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22054 branch November 6, 2024 11:33
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
* Refs #22054: Add Regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22054: Add fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit fe29535)
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
* Refs #22054: Add Regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22054: Add fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit fe29535)
MiguelCompany pushed a commit that referenced this pull request Nov 7, 2024
* Refs #22054: Add Regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22054: Add fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit fe29535)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Nov 7, 2024
* Refs #22054: Add Regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22054: Add fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit fe29535)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants