Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21706] Feature: Extended incompatible QoS for monitor service #5385

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 6, 2024

Description

This PR adds the Extended incompatible QoS for monitor service feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Mario-DL and others added 3 commits November 5, 2024 11:33
…5294)

* Refs #21756: Update Monitor Service IDL

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21756: Update Monitor Service Types

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21756: BB Tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21756: little bugfix in guids collections

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21756: Make processed msgs count cleaner

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…5345)

* Refs #21841: Update IProxyObserver

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Add event hooks in PDP and EDP

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Add new IProxyObserver implementor methods in MonitorServiceListener

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Update MonitorService class

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Update unittests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Apply Miguels review

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Add mmissing methods to mock

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Apply second round of suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Apply third rev round

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21841: Apply last suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany MiguelCompany merged commit d607eef into master Nov 8, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/21706/main branch November 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants