-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17283] Fix issues in Dynamic Network Interfaces (backport #5282) (backport #5304) #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of 66ec998 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-5304
branch
from
November 8, 2024 10:47
b7f9a62
to
12ac216
Compare
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-5304
branch
from
November 8, 2024 10:54
12ac216
to
f78bf91
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 8, 2024 10:54
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-5304
branch
from
November 8, 2024 10:58
f78bf91
to
71e0f25
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 8, 2024 10:58
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-5304
branch
from
November 8, 2024 11:04
71e0f25
to
9818c2a
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 8, 2024 11:06
* Fix issues in Dynamic Network Interfaces (#5282) * Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 91bd7c8) * Refs #17283: Fix conflicts Signed-off-by: eProsima <jesuspoderoso@eprosima.com> * Refs #17283: Keep original PR functionality Signed-off-by: eProsima <jesuspoderoso@eprosima.com> * Refs #17283: Please uncrustify Signed-off-by: eProsima <jesuspoderoso@eprosima.com> * Restore discovery server list check code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Make backported methods static methods instead of inline code. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Methods get_default_xxx_locators with output argument. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Only update attributes when necessary. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: eProsima <jesuspoderoso@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: eProsima <jesuspoderoso@eprosima.com> (cherry picked from commit 66ec998) Signed-off-by: Miguel Company <miguelcompany@eprosima.com> # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/communication/PublisherMain.cpp # test/communication/SubscriberMain.cpp # test/dds/communication/SubscriberMain.cpp # test/dds/communication/SubscriberModule.hpp # test/dds/communication/security/PublisherModule.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.cpp # test/dds/communication/security/SubscriberModule.hpp
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-5304
branch
from
November 8, 2024 11:07
9818c2a
to
c84b5b8
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 8, 2024 11:08
JesusPoderoso
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a regression test based in Ubuntu containers for one long standing issue with dynamic network interfaces that was preventing communication when a participant was created with no network interfaces available.
It fixes the issue by correctly updating the locators on the proxy data of the participant, and all its readers or writers created with the default locators.
@Mergifyio backport 3.0.x 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5282 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #5304 done by [Mergify](https://mergify.com).