Merge pull request #216 from line-o/feat/install-errors

more meaningful installation error messages
eXist-db · Feb 4, 2023 · e02da38 · e02da38
2 parents 1428e47 + 13ba419
commit e02da38
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/semantic-release.yml b/.github/workflows/semantic-release.yml
@@ -13,7 +13,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         node-version: [14, 16, 18]
-        exist-version: [latest, release, 5.4.1, 4.10.0]
+        exist-version: [latest, release, 5.5.1, 4.11.1]
     services:
       # Label used to access the service container
       exist:

diff --git a/index.js b/index.js
@@ -309,12 +309,16 @@ function install (client, options) {
 
     client.app.upload(file.contents, xarName)
       .then(response => {
-        if (!response.success) { return callback(new PluginError('gulp-exist', 'XAR was not uploaded')) }
+        if (!response.success) {
+          return callback(new PluginError('gulp-exist', `XAR was not uploaded: ${response.error}`))
+        }
         log(`Install ${xarName}`)
         return client.app.install(xarName, customPackageRepoUrl)
       })
       .then(response => {
-        if (!response.success) { return callback(new PluginError('gulp-exist', 'XAR Installation failed')) }
+        if (!response.success) {
+          return callback(new PluginError('gulp-exist', `XAR Installation failed: ${response.error}`))
+        }
         if (response.result.update) {
           log('Application was updated')
           return callback(null, response)