patch: rename transitionfrom to static transition

packages/vest-utils/src/SimpleStateMachine.ts

@@ -15,15 +15,15 @@ export type TStateMachine<S extends string, A extends string> = {
 export type TStateMachineApi<S extends string, A extends string> = {
  getState: CB<S>;
  transition: (action: A, payload?: any) => void;
- transitionFrom: (from: S, action: A, payload?: any) => S;
+ staticTransition: (from: S, action: A, payload?: any) => S;
 };
 
 export function StateMachine<S extends string, A extends string>(
  machine: TStateMachine<S, A>
 ): TStateMachineApi<S, A> {
  let state = machine.initial;
 
- const api = { getState, transition, transitionFrom };
+ const api = { getState, transition, staticTransition };
 
  return api;
 
@@ -32,11 +32,11 @@ export function StateMachine<S extends string, A extends string>(
  }
 
  function transition(action: A, payload?: any): S {
- return (state = transitionFrom(state, action, payload));
+ return (state = staticTransition(state, action, payload));
  }
 
  // eslint-disable-next-line complexity
- function transitionFrom(from: S, action: A, payload?: any): S {
+ function staticTransition(from: S, action: A, payload?: any): S {
  const transitionTo =
  machine.states[from]?.[action] ??
  // @ts-expect-error - This is a valid state

packages/vest-utils/src/__tests__/SimpleStateMachine.test.ts

@@ -296,7 +296,7 @@ describe('SimpleStateMachine', () => {
  });
  });
 
- describe('transitionFrom', () => {
+ describe('staticTransition', () => {
  describe('When the transition is valid', () => {
  it('Should return the new state', () => {
  const machine = StateMachine({
@@ -314,7 +314,27 @@ describe('SimpleStateMachine', () => {
  },
  });
  expect(machine.getState()).toBe('idle');
- expect(machine.transitionFrom('idle', 'click')).toBe('loading');
+ expect(machine.staticTransition('idle', 'click')).toBe('loading');
+ });
+
+ it('Should not modify the state', () => {
+ const machine = StateMachine({
+ initial: 'idle',
+ states: {
+ error: {},
+ idle: {
+ click: 'loading',
+ },
+ loading: {
+ success: 'success',
+ error: 'error',
+ },
+ success: {},
+ },
+ });
+ expect(machine.getState()).toBe('idle');
+ machine.staticTransition('idle', 'click');
+ expect(machine.getState()).toBe('idle');
  });
  });
 
@@ -335,7 +355,7 @@ describe('SimpleStateMachine', () => {
  },
  });
  expect(machine.getState()).toBe('idle');
- expect(machine.transitionFrom('idle', 'finish')).toBe('idle');
+ expect(machine.staticTransition('idle', 'finish')).toBe('idle');
  });
  });
 
@@ -356,7 +376,7 @@ describe('SimpleStateMachine', () => {
  },
  });
  expect(machine.getState()).toBe('idle');
- expect(machine.transitionFrom('idle', 'click')).toBe('idle');
+ expect(machine.staticTransition('idle', 'click')).toBe('idle');
  });
  });
 
@@ -377,7 +397,7 @@ describe('SimpleStateMachine', () => {
  },
  });
  expect(machine.getState()).toBe('idle');
- expect(machine.transitionFrom('idle', 'click')).toBe('loading');
+ expect(machine.staticTransition('idle', 'click')).toBe('loading');
  });
  });
  });

packages/vest/src/core/isolate/IsolateTest/VestTestMutator.ts

@@ -61,6 +61,10 @@ export class VestTestMutator {
  status: TestStateMachineAction,
  payload?: any
  ): void {
- test.status = TestStateMachine.transitionFrom(test.status, status, payload);
+ test.status = TestStateMachine.staticTransition(
+ test.status,
+ status,
+ payload
+ );
  }
 }