Feature: new enforce rule - isURL #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
almoghaimo
commented
Jul 26, 2023
There was a problem hiding this comment.
@ealush this pr is ready for review,
Do you know how I'll be able to assign you as a reviewer?
ealush
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Awesome @almoghaimo! Thank you for that, and so sorry for taking this long to respond. This looks amazing. Merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new feature for the n4s package, the New isURL enforce rule provides functionality to validate URL values.
This rule exposes the
validator.jsisURL rule and accepts the same options.The file name is not
url.tslike the other rules files convention (ex:email.ts) because jest is not able to find the file, and instead, it searches for the url module on node_modules, I currently wasn't able to fix it.