Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for CI #294

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Fixes for CI #294

merged 4 commits into from
Aug 15, 2024

Conversation

skosukhin
Copy link
Collaborator

@skosukhin skosukhin commented Aug 15, 2024 •
edited
Loading

  1. Work around the issue with the signature checker on Lumi: push revisions as branches and not as tags.
  2. Reduce code duplication in the CI description.
  3. Avoid failing the clean-up when removing a GitLab pipeline that has not been created yet.
  4. Work around the issue with the old node runtime on Daint (see checkout@v3 using node20 instead of node16 actions/checkout#1809).

@skosukhin skosukhin changed the title Fix Lumi CI Fixes for CI Aug 15, 2024
RobertPincus
RobertPincus approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always.

@RobertPincus RobertPincus merged commit 6685a94 into develop Aug 15, 2024
35 checks passed
@RobertPincus RobertPincus deleted the try-fix-lumi branch August 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertPincus RobertPincus RobertPincus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skosukhin @RobertPincus