Facturx 2.3 #63
Facturx 2.3 #63
Conversation
guillaume-sainthillier
force-pushed
the
facturx-2.3
branch
from
1276f6f to
e19b3e5
Compare
There was a problem hiding this comment.
Hi @guillaume-sainthillier. Sorry for the late response and thank your for your contribution.
The PR is quite large and i would like you to ask, that you shrink it to just adding the examples, and adding the fields which are missing.
There are some refactors that i would like to discuss. Therefore, i opened the discussion board in this repository.
| /** @return iterable<int, array<SplFileInfo>> */ | ||
| public function dataProvider(): iterable |
There was a problem hiding this comment.
| /** @return iterable<int, array<SplFileInfo>> */ | |
| public function dataProvider(): iterable | |
| /** @return iterable<string, array<SplFileInfo>> */ | |
| public function dataProvider(): iterable |
| @@ -44,7 +44,7 @@ public function dataProvider(): array | |||
|
|
|||
| $buffer = []; | |||
| foreach ($finder as $file) { | |||
| $buffer[$file->getFilename()] = [$file]; | |||
| yield [$file]; | |||
There was a problem hiding this comment.
| yield [$file]; | |
| yield $file->getFilename() => [$file]; |
Your change to generator is fine. But i would like to have the filename as dataset name. If the test fails, the offending example is easily found.
|
hello @BolZer, thanks for your update! What would you like me to remove in this PR? I can surely remove the yield from phpunit tests provider but mainly other changes are related to adding new fields and making tests pass. Are you talking about changes related to uses of |
Hello there, i've added more fields from official specification files with tests