Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing *marginaleffects* test #1049

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix failing *marginaleffects* test #1049

merged 2 commits into from
Nov 26, 2024

Conversation

strengejacke
Copy link
Member

Fixes #1048

@vincentarelbundock
Copy link
Contributor

This will likely fail in future version, since the old behavior is desired. Proposed solution here:

#1048 (comment)

@strengejacke
Copy link
Member Author

ok, thanks! Will make the test conditional on version 1 then

@strengejacke strengejacke merged commit d9df1dd into main Nov 26, 2024
19 of 20 checks passed
@strengejacke strengejacke deleted the strengejacke/issue1048 branch November 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentarelbundock vincentarelbundock Awaiting requested review from vincentarelbundock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing *marginaleffects* test
2 participants
@strengejacke @vincentarelbundock