Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission 0.21.2 #903

Merged
merged 18 commits into from
Sep 16, 2023
Merged

CRAN submission 0.21.2 #903

merged 18 commits into from
Sep 16, 2023

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Sep 13, 2023

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #903 (1db0fce) into main (1bb0cd6) will decrease coverage by 0.01%.
The diff coverage is 70.00%.

❗ Current head 1db0fce differs from pull request most recent head fcc263d. Consider uploading reports for the commit fcc263d to get more accurate results

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   57.25%   57.25%   -0.01%     
==========================================
  Files         186      186              
  Lines       13878    13881       +3     
==========================================
+ Hits         7946     7947       +1     
- Misses       5932     5934       +2     
Files Changed Coverage Δ
R/1_model_parameters.R 85.83% <ø> (ø)
R/2_ci.R 100.00% <ø> (ø)
R/bootstrap_model.R 53.04% <ø> (ø)
R/bootstrap_parameters.R 92.10% <ø> (ø)
R/cluster_discrimination.R 0.00% <ø> (ø)
R/cluster_performance.R 32.14% <ø> (ø)
R/display.R 0.00% <ø> (ø)
R/dominance_analysis.R 62.28% <ø> (ø)
R/print_html.R 0.00% <0.00%> (ø)
R/print_md.R 0.00% <0.00%> (ø)
... and 7 more

@strengejacke
Copy link
Member Author

@IndrajeetPatil I think I already asked this, but I forgot how to address this:
check-strict fails on Ubuntu for this reason:

❯ checking package dependencies ... NOTE
Packages suggested but not available for checking: 'cplm', 'panelr'

Is there any way to avoid that this note results in a check failure?

@strengejacke
Copy link
Member Author

And this issue: https://github.com/easystats/parameters/actions/runs/6174249881/job/16758433068?pr=903

Is it temporary? I can't exactly figure out what's going on here.

@IndrajeetPatil
Copy link
Member

And this issue: https://github.com/easystats/parameters/actions/runs/6174249881/job/16758433068?pr=903

Is it temporary? I can't exactly figure out what's going on here.

This should be fixed. Dependency graphs have changed and so some more packages needed to be ignored on older versions.

@IndrajeetPatil
Copy link
Member

@IndrajeetPatil I think I already asked this, but I forgot how to address this: check-strict fails on Ubuntu for this reason:

❯ checking package dependencies ... NOTE
Packages suggested but not available for checking: 'cplm', 'panelr'

Is there any way to avoid that this note results in a check failure?

I had already set the needed environment variable to false, so I honestly don't understand why the R CMD check is still failing.

@strengejacke strengejacke merged commit 700067b into main Sep 16, 2023
23 of 25 checks passed
@strengejacke strengejacke deleted the rc_0.21.2 branch September 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants