Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDS plugin filling Koha logs with needless warnings #53 #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minusdavid
Copy link
Contributor

For the most part, these are warnings about the experimental use
of given/when.

Koha doesn't use given/when for this reason, and there have been
patches to remove its use in the past:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479

I thought there was a line in Koha's coding guidelines but I
haven't found it. It might be one of those things which is
implicitly understood in the Koha community but isn't recorded
explicitly anywhere.

This patch removes the use of given/when in eds-methods.pl and
replaces it with if statements.

For the most part, these are warnings about the experimental use
of given/when.

Koha doesn't use given/when for this reason, and there have been
patches to remove its use in the past:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479

I thought there was a line in Koha's coding guidelines but I
haven't found it. It might be one of those things which is
implicitly understood in the Koha community but isn't recorded
explicitly anywhere.

This patch removes the use of given/when in eds-methods.pl and
replaces it with if statements.
@minusdavid
Copy link
Contributor Author

This pull request is to address #53

@minusdavid
Copy link
Contributor Author

Note that I've only performed a syntax check using "perl -c". I haven't actually tested this code myself. At a glance, it looks like it should work, but the maintainer should test it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant