Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox test script with ballot test improvement #2528

Closed

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Jun 15, 2023

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Rewrote the most part of integration-tests/README.md for external user
Reorganized integration-tests/package.json for readability
Improved integration-tests/sandbox-script.sh & integration-tests/sandbox-ballot-operation.spec.ts to be robust

ac10n and others added 15 commits May 24, 2023 13:43
* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts
* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts
* Update nairobi in other files

* undo changes to versioned docs

* chore: rename PtNairob to PtNairobi
* feat: updated GasLimit for reveal in Nairobi

fix #2447

* fix: change mumbai tests to also run for later protocols

* chore: fix failing unit tests

* Fix failoing integration test

* chore: rename PtNairob to PtNairobi

* chore: apply changes as suggested by davis

* chore: remove the unused logic

* chore: fix values for the consumedMilligas in failing tests

* fix unit tests after changes to reveal gasLimit

* chore: revert gas limit for reveal to 2200
* fixed contract call estimate prep to check for reveal (#2502)

* fixed contract call estimate prep to check for reveal

* changed logic slightly

* added keygen diagram to integration test readme (#2504)

* added keygen diagram

* text improvement

* typo fix

* Upgrade netlify-cli to fix the android dependency problem (#2496)

* Re-create package-lock.json in root and website to trigger the problem

* Upgrade netlify-cli

* update most dependencies in website

* Add EventSchema to ContractAbstraction

* Remove duplicate events

* fix typo

* test: added integration test for events in ContractAbstraction

* docs: add documentation for eventSchema

---------

Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com>
Co-authored-by: Michael Kernaghan <michaelkernaghan@ecadlabs.com>
* removed mumbai references in v17

* add block call for mumbai to get protocol constants

* remove extraneous line

* updated assertion values

* updated assertion

* fix test protocol constants

* addressed pr comment and added proto15 tests
* Configure Nairobinet for Integration Tests (#2492)

* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts

* updated types for sc_rollup_cement in N

* updated unit test for updated types

---------

Co-authored-by: AlirezaHaghshenas <alirezahaghshenas@gmail.com>
@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 9a05306
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/64c972b8f721cd0008e607fd
😎 Deploy Preview https://deploy-preview-2528--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hui-an-yang hui-an-yang mentioned this pull request Jun 15, 2023
9 tasks
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/utils@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@17.1.1-121a7cd-- --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

A new deploy preview is available on Netlify at https://121a7cd--tezostaquito.netlify.app

@hui-an-yang hui-an-yang marked this pull request as ready for review June 20, 2023 15:53
const tezos = lib;
let keyPkh: string = "";
let keyInitialBalance: BigNumber = new BigNumber(0);

(async () => {
await setup(true);
// when running sandbox test need to wait till flextesa is ready
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another way to check if the sandbox is ready?


describe(`Test Proposal and Ballot operation in ${protocol.substring(0, 8)} with flextesa`, () => {
beforeAll(async (done) => {
await sleep(15 * 1000); // wait 15 seconds for flextesa to be ready
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: is there another way to make sure the sandbox is ready?

@hui-an-yang hui-an-yang deleted the sandbox-test-script-with-ballot-test-improvement branch December 4, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants