Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to operation estimation errors in batches (#2797) #2798

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Jan 17, 2024

Follow up PR from @sergey-kintsel's contribution at #2797

It allows to find the faulty operation
Otherwise, it's just random guessing why it failed

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

It allows to find the faulty operation
Otherwise, it's just random guessing why it failed

Co-authored-by: Sergey Kintsel <sergey.kintsel@trili.tech>
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 807b89f
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65a8755e0da00100081cd0c2
😎 Deploy Preview https://deploy-preview-2798--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 17, 2024

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/utils@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@17.5.2-462c992-- --registry https://npm.preview.tezostaquito.io/

Copy link

github-actions bot commented Jan 17, 2024

A new deploy preview is available on Netlify at https://462c992--tezostaquito.netlify.app

@hui-an-yang hui-an-yang marked this pull request as ready for review January 18, 2024 16:43
Copy link
Contributor

@dsawali dsawali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good addition to our error responses.

@dsawali
Copy link
Contributor

dsawali commented Jan 19, 2024

Thank you again for your contribution @sergey-kintsel

@hui-an-yang hui-an-yang merged commit 83cc484 into master Jan 19, 2024
12 checks passed
@hui-an-yang hui-an-yang deleted the batch-estimation-info branch January 19, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants