-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to allow debug memory problems #80
base: latest
Are you sure you want to change the base?
Conversation
… cpp types in method callers. remove assert and debug print noise.
…uct class parameter to be able to pass null. handle name clash between lowercased method and property names. remove some brokens and add others.
…constructors. remove many fixed brokens.
…ration. fix global function symbol collision between C and C++.
…fix broken array parameters.
5a88997
to
414480b
Compare
Hi @mingodad, wondering if you had a chance to figure out what issue that you ran into was? As I had mentioned, I think it likely had to do with a memory management mix-up. In your PR, I see usage of malloc_usable_size() but that will not work properly as that does not return the size that was requested. (I have made that mistake before). We cannot merge these changes to use regular malloc/calloc/realloc when _DEBUG is defined because of this, and also because the code should go through the regular pathways which supports our own MemoryGuard memory checker and the eC which makes a huge performance difference for small allocation on Windows platforms. Please let me know if I can be of further help. |
1028167
to
7277524
Compare
abe6262
to
171551b
Compare
d7dcc75
to
adda21c
Compare
usage: make V=1 DEBUG=1 DBGWRAPPER=valgrind DISABLE_MEMMGR=1 DESTDIR=$HOME/local