Skip to content

Commit

Permalink
Fixing CI failures
Browse files Browse the repository at this point in the history
  • Loading branch information
eckz committed Aug 13, 2024
1 parent 9097653 commit b01c5eb
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ missing_docs = "warn"
[dependencies]
serde = { version = "1.0" }
thiserror = "1.0"
bevy = { version = "0.14", default-features = false, features = ["multi_threaded"] }
bevy = { version = "0.14", default-features = false }

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
toml = "0.8"
Expand All @@ -23,6 +23,7 @@ serde_json = "1.0"

[dev-dependencies]
bevy = { version = "0.14", default-features = false, features = [
"multi_threaded",
"bevy_render",
"bevy_winit",
"webgl2",
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
//!# }
//!
//! App::new()
//! .add_plugins(DefaultPlugins)
//! .add_plugins(PreferencesPlugin::persisted_with_app_name("YourAppName"))
//! .register_preferences::<ExampleSettings>();
//! ```
Expand Down
2 changes: 1 addition & 1 deletion src/reflect_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ impl PreferencesReflectMap {
let key = self.effective_type_path_from_type_info(type_info);

let type_registry = &self.type_registry_arc.read();
let registry_data = PreferencesRegistryData::from_type_info(&type_registry, type_info);
let registry_data = PreferencesRegistryData::from_type_info(type_registry, type_info);

let value = registry_data.apply_from_reflect(value);

Expand Down
7 changes: 0 additions & 7 deletions src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ fn preferences_registry_fail(full_path: &str, short_path: &str, msg: &str) -> !
}

impl<'a> PreferencesRegistryData<'a> {
pub fn from_type_path<T: TypePath>(type_registry: &'a TypeRegistry) -> Self {
let Some(type_registration) = type_registry.get_with_type_path(T::type_path()) else {
preferences_registry_fail(T::type_path(), T::short_type_path(), "is not registered");
};
Self::from_type_registration(type_registration)
}

pub fn from_type_info(type_registry: &'a TypeRegistry, type_info: &TypeInfo) -> Self {
let Some(type_registration) = type_registry.get(type_info.type_id()) else {
preferences_registry_fail(
Expand Down

0 comments on commit b01c5eb

Please sign in to comment.