-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxii2 major Bug fixes and enhancements for production use #272
Open
priyank-bhuva-crestdata
wants to merge
20
commits into
eclecticiq:master
Choose a base branch
from
priyank-bhuva-crestdata:taxii2-merged-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Taxii2 major Bug fixes and enhancements for production use #272
priyank-bhuva-crestdata
wants to merge
20
commits into
eclecticiq:master
from
priyank-bhuva-crestdata:taxii2-merged-fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added example on how to define accounts with permissions for taxii2 and taxii1. - Fixed authentication for taxii2. Now accounts can be defined to access private collections with 'read' or 'modify' access.
When a collection that does not exist is used in a data-configuration file, a warning is produced
If no credentials are provided and you try to access a public collection, there is an error. Now it has been fixed.
Also expanded the example for taxii2 data-configuration-accounts
The script can be used to test push, pull, and subscribe functionality with taxii2-client
docker-compose.yml was missing version and services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all changes from Open PR by aams-eam.
Other bug fixes and enhancements:
default_pagination_limit
andmax_pagination_limit
parameters formanifest
andobjects
get endpoints to avoid errors because of large response size.opentaxii-create-account
command to supportadmin
argument.add_objects
method to define modified time andspec_version
parameters if not provided in POST data.spec_version
value in response instead of object type.