model.base: Rename ModelingKind to ModellingKind #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 3.0 the Enum `ModelingKind` has been renamed to `ModellingKind`. This commit renames the class definition and all its occurences in the code.
|
Note, that the failing CI is due to a mypy error, that seems to have nothing to do with the renaming. |
jkhsjdhjs
suggested changes
Aug 11, 2023
| @@ -388,15 +388,15 @@ def _child_text_mandatory_mapped(parent: etree.Element, child_tag: str, dct: Dic | |||
| return _get_text_mandatory_mapped(_get_child_mandatory(parent, child_tag), dct) | |||
|
|
|||
|
|
|||
| def _get_modeling_kind(element: etree.Element) -> model.ModelingKind: | |||
| def _get_kind(element: etree.Element) -> model.ModellingKind: | |||
| """ | |||
| Returns the modeling kind of an element with the default value INSTANCE, if none specified. | |||
|
|
|||
| :param element: The xml element. | |||
| :return: The modeling kind of the element. | |||
- In docstrings, also as "modeling kind" - In JSON schema and XSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 3.0 the Enum
ModelingKindhas beenrenamed to
ModellingKind.This commit renames the class definition and all
its occurences in the code.
See also here in the Spec