model.base: make extending a ConstrainedList atomic
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously partial additions of elements via a call to `.extend()` were possible, since the `.extend()` method of the superclass simply calls `.append()` for each item, which in turn calls `.insert()`. Thus, if the hook call for one item raised an exception, all previous items had already been added.
jkhsjdhjs
force-pushed
the
fix/constrained_list_extend_atomicity
branch
from
5ee39dc
to
2dc720e
Compare
|
This looks good to me as well. Give me a thumbs up if it's ready to be merged. |
s-heppner
reviewed
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously partial additions of elements via a call to
.extend()werepossible, since the
.extend()method of the superclass simply calls.append()for each item, which in turn calls.insert(). Thus, if thehook call for one item raised an exception, all previous items had
already been added.
Furthermore, this PR adds tests for the atomicity of extension and deletion operations of
ConstrainedList.