Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.base: replace continue with break in NamespaceSet.remove() #126

Merged

Conversation

jkhsjdhjs
Copy link
Contributor

If an item has been found, it doesn't make any sense to continue iterating the remaining items. Thus, this continue is replaced by a break, to break out of the loop once an item has been found.

If an item has been found, it doesn't make any sense to continue
iterating the remaining items. Thus, this `continue` is replaced by a
`break`, to break out of the loop once an item has been found.
@s-heppner
Copy link
Contributor

Fair point and well observed!
I'd rebase this if you say it's ready.

@s-heppner s-heppner merged commit d96c605 into eclipse-basyx:improve/V30 Oct 3, 2023
6 checks passed
@s-heppner s-heppner deleted the fix/namespaceset_remove branch October 3, 2023 11:02
@s-heppner s-heppner added the v3.0 label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants