model.base: add item_id_{set,del}_hook to NamespaceSet
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
force-pushed
the
feature/namespaceset_id_hooks
branch
from
4c2bf75
to
0692acd
Compare
These hooks allow dynamically assigning a value to the identifying attribute of an object whenever it is added to a `NamespaceSet` (`item_id_set_hook`). Furthermore, the `item_id_del_hook` allows unsetting the identifying attribute whenever an object is removed from a `NamespaceSet`. This functionality is necessary for the implementation of `SubmodelElementLists`, because there we need to store items without an identifying attribute in a `NamespaceSet`.
jkhsjdhjs
force-pushed
the
feature/namespaceset_id_hooks
branch
from
0692acd
to
3abec1a
Compare
|
Looks good to me. Is this ready to be rebased? |
|
Yep 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hooks allow dynamically assigning a value to the identifying
attribute of an object whenever it is added to a
NamespaceSet(
item_id_set_hook). Furthermore, theitem_id_del_hookallowsunsetting the identifying attribute whenever an object is removed
from a
NamespaceSet.This functionality is necessary for the implementation of
SubmodelElementLists, because there we need to store items withoutan identifying attribute in a
NamespaceSet.This PR depends on #130.