Remove binary files from test files for compliance tool #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As binary files are not appropriate for git, we decided instead to create folders with the exact structure like in .aasx files and zip these folder when initializing a ComplianceToolAASXTest.
|
Thank you for the initiative! |
Instead init() use setUpClass() to generate AASX files with zipped dirs and delete these AASX files after tests are finished.
It will be generated in ComplianceToolAASXTest.setUpClass()
jkhsjdhjs
reviewed
Oct 19, 2023
As other tests also need AASX files, we cannot remove AASX files after all Tests in ComplianceToolAASXTest are run. That is why tearDownClass() was removed
As other tests also need AASX files, we cannot generate AASX files in ComplianceToolAASXTest, because other tests can be run before or without tests from ComplianceToolAASXTest.
@s-heppner the data files in test files have actually line breaks. Only meta files in those test files dont have line breaks, unfortunately I cannot pretty-print them, because otherwise the equality checking in tests doesnt work. |
|
Alright, looks good to me. Tell me if it is ready to be merged |
|
@s-heppner it is ready |
Frosty2500
pushed a commit
to rwth-iat/basyx-python-sdk
that referenced
this pull request
Aug 22, 2024
…x#143) * Remove binary files from test files As binary files are not appropriate for git, we decided instead to create folders with the exact structure like in .aasx files and zip these folder when initializing a ComplianceToolAASXTest. * Add setUpClass() and tearDownClass(). Instead init() use setUpClass() to generate AASX files with zipped dirs and delete these AASX files after tests are finished. * Remove test_empty.aasx binary It will be generated in ComplianceToolAASXTest.setUpClass() * Remove ComplianceToolAASXTest.tearDownClass() As other tests also need AASX files, we cannot remove AASX files after all Tests in ComplianceToolAASXTest are run. That is why tearDownClass() was removed * Move generation of AASX files to __init__.py As other tests also need AASX files, we cannot generate AASX files in ComplianceToolAASXTest, because other tests can be run before or without tests from ComplianceToolAASXTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As binary files are not appropriate for git, we decided instead to create folders with the exact structure like in
.aasxfiles and zip these folders when initializing aComplianceToolAASXTest.