Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.base: improve NamespaceSet #155

Merged
merged 3 commits into from
Nov 14, 2023
Merged

model.base: improve NamespaceSet #155

merged 3 commits into from
Nov 14, 2023

Commits on Nov 8, 2023

  1. Refactor NamespaceSet 

    - Refactored `NamespaceSet.add()` as too big
  - Extracted some methods, in particular `_execute_item_del_hook`. I used the method also in other places
- As we check different constraints for uniqueness in the namespace, I defined ATTRIBUTES_CONSTRAINT_IDS. The dict will be used when throwing exception. The solution with the dict is temporary, we need other solution here.
    @zrgt
    zrgt committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4515de1 View commit details
    Browse the repository at this point in the history

  2. Fix of namespace and its tests 

    - Use correct constraint ids for each NamespaceSet in tests, use 000 if not constraint id is suitable
    @zrgt
    zrgt committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    79a360c View commit details
    Browse the repository at this point in the history

  3. Fix mypy

    @zrgt
    zrgt committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    faeed67 View commit details
    Browse the repository at this point in the history