Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter.json: Update Schema to comply with v3.0 #159

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

s-heppner
Copy link
Contributor

This updates the JSON Schema with the missing changes of the specified schema.

However, as noted in #72, we did not include the regex patterns for the File.

Please note, that according to [eclipse-basyx#72], we decided not
to include the `File` pattern, since the
specification is wrong at this.

[eclipse-basyx#72](eclipse-basyx#72)
@s-heppner s-heppner marked this pull request as draft November 14, 2023 14:47
@s-heppner
Copy link
Contributor Author

Can someone please have a look at this? I've been at it for hours and I can't find the remaining problem with the schema.

It appears to be something with the SubmodelElementList at the test_demo_full_example.json and corresponding AASX file in test/compliance_tool/files, however, when I start modifying those files, it seems like everything else starts breaking.

These went unnoticed previously since the JSON schema doesn't prohibit
additional attributes. Now that the `modelType` is defined as a constant
string per definition, a `Property` object only matches against the
corresponding definition, allowing more strict validation, that catches
errors such as these null values.
Copy link
Contributor

@jkhsjdhjs jkhsjdhjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@s-heppner s-heppner marked this pull request as ready for review November 14, 2023 16:58
@s-heppner s-heppner merged commit 24d4cf3 into eclipse-basyx:improve/V30 Nov 14, 2023
6 checks passed
@s-heppner s-heppner deleted the update/JSONschema branch November 14, 2023 20:39
@s-heppner s-heppner added the v3.0 label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants