-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapter: Refactor XML and JSON de-/serialization methods #165
Closed
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc48262 - Browse repository at this point
Copy the full SHA fc48262View commit details -
adapter.xml: Update XSD of
valueDataType
andExtension
This commit remanes `valueDataType_t` from the XSD to `valueDataType`. Furthermore, it adds a missing `<reference>` tag around the `refersTo` References of `Extension`.
Configuration menu - View commit details
-
Copy full SHA for d3cdbfe - Browse repository at this point
Copy the full SHA d3cdbfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c276f7 - Browse repository at this point
Copy the full SHA 0c276f7View commit details -
adapter.xml: Change order of
SubmodelElementList
objectsThe current order of the elements in `SubmodelElementList` was wrong. This updates the order.
Configuration menu - View commit details
-
Copy full SHA for 9027a8e - Browse repository at this point
Copy the full SHA 9027a8eView commit details -
adapter.xml: Remove
<aas:kind>
fromSubmodelElement
s in XSDVersion 3.0 of the spec removes the attribute `kind` from `SubmodelElement`s. While we already implemented this, it was still missing in the XSD Schema, as well as the examples. This commit fixes that.
Configuration menu - View commit details
-
Copy full SHA for 3d80e0c - Browse repository at this point
Copy the full SHA 3d80e0cView commit details
Commits on Nov 15, 2023
-
adapter.xml: Fix deserialization for
Extension
Currently, the XML deserialization missed the `<aas:refersTo>` wrapper around the single references inside `Extension.refers_to`. This commit fixes that.
Configuration menu - View commit details
-
Copy full SHA for 6071934 - Browse repository at this point
Copy the full SHA 6071934View commit details -
model.Extension: Change refers_to to be of type
List[Reference]
Currently, `Extension.refers_to` is declared as a `Iterable[Reference]`. This implies, that we can not necessarily check, whether or not the attribute is empty or not. This creates a problem with the XML serialization, since the `<aas.refersTo>` element should only appear if there is at least one `Reference` inside. This commit changes the `Extension.refers_to` to be a list of `Reference`s, as well as adapting a more clear check whether or not the attribute is empty in `adapter.xml.xml_serialization`.
Configuration menu - View commit details
-
Copy full SHA for 58f4597 - Browse repository at this point
Copy the full SHA 58f4597View commit details -
Configuration menu - View commit details
-
Copy full SHA for a14eed9 - Browse repository at this point
Copy the full SHA a14eed9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c66a4bd - Browse repository at this point
Copy the full SHA c66a4bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a49abd - Browse repository at this point
Copy the full SHA 2a49abdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05e423d - Browse repository at this point
Copy the full SHA 05e423dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e21ec3 - Browse repository at this point
Copy the full SHA 3e21ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a6c51 - Browse repository at this point
Copy the full SHA 34a6c51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.