Fix negative xsd range edge cases #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrimaz
changed the title
jkhsjdhjs
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
LGTM 👍, thanks for extending the unittests!
@s-heppner can you approve the workflows?
|
Thank you very much for your contribution! |
jkhsjdhjs
pushed a commit
to rwth-iat/basyx-python-sdk
that referenced
this pull request
Dec 7, 2023
The current implementation uses the `abs()` function to check that the value is inside the range. However, the range is not symmetric. For example, for a [byte](https://www.w3.org/TR/xmlschema11-2/#byte), which is between [-128, 127], the value of [maxInclusive](https://www.w3.org/TR/xmlschema11-2/#dt-maxInclusive) should be 127, and [minInclusive](https://www.w3.org/TR/xmlschema11-2/#dt-minInclusive) should be -128.
s-heppner
pushed a commit
that referenced
this pull request
Dec 11, 2023
The current implementation uses the `abs()` function to check that the value is inside the range. However, the range is not symmetric. For example, for a [byte](https://www.w3.org/TR/xmlschema11-2/#byte), which is between [-128, 127], the value of [maxInclusive](https://www.w3.org/TR/xmlschema11-2/#dt-maxInclusive) should be 127, and [minInclusive](https://www.w3.org/TR/xmlschema11-2/#dt-minInclusive) should be -128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation use the abs function to check the value be inside the range. But the range is not symetric for example byte is between [-128,127] the value of ·maxInclusive· to be 127 and ·minInclusive· to be -128`