-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model.base: add id_short path resolution #249
Merged
s-heppner
merged 5 commits into
eclipse-basyx:main
from
rwth-iat:feature/id_short_path_resolution
Mar 14, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c658c5
model.base: add id_short path resolution
jkhsjdhjs 3dd07f9
model.base: improve id_short resolution error messages
jkhsjdhjs 70932a7
test_base: add test for non-numeric `SubmodelElementList` Key values
jkhsjdhjs ef0a173
model.base: improve two docstrings
jkhsjdhjs 2243ea6
model.base: improve a `ModelReference.resolve()` error message
jkhsjdhjs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very elegant but indeed really hard to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
map(lambda...
expression is pretty clean, but callingget_referable()
and manually supplyingself
asitem
, becauseitem
is not necessarily aUniqueIdShortNamespace
, is not. However, I think it's acceptable becauseget_referable()
checks the type ofself
in the first iteration and because it's all documented via comments, inModelReference.resolve()
as well asUniqueIdShortNamespace.get_referable()
. It's the only solution I could come up with that doesn't require duplicate error messages, i.e. having the same check with the same error message in both functions.