Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model.base: add id_short path resolution #249
model.base: add id_short path resolution #249
Changes from 4 commits
4c658c5
3dd07f9
70932a7
ef0a173
2243ea6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very elegant but indeed really hard to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
map(lambda...
expression is pretty clean, but callingget_referable()
and manually supplyingself
asitem
, becauseitem
is not necessarily aUniqueIdShortNamespace
, is not. However, I think it's acceptable becauseget_referable()
checks the type ofself
in the first iteration and because it's all documented via comments, inModelReference.resolve()
as well asUniqueIdShortNamespace.get_referable()
. It's the only solution I could come up with that doesn't require duplicate error messages, i.e. having the same check with the same error message in both functions.