-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformulate Constraints for V3.0 #85
Merged
s-heppner
merged 16 commits into
eclipse-basyx:improve/V30
from
rwth-iat:ConstraintsReformulated
Jun 29, 2023
Merged
Reformulate Constraints for V3.0 #85
s-heppner
merged 16 commits into
eclipse-basyx:improve/V30
from
rwth-iat:ConstraintsReformulated
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraint was not implemented in docs of `base.Qualifier` Changed status in `constraints.rst` to `done`
@s-heppner Can you review this |
s-heppner
requested changes
Jun 20, 2023
The information under `WIP` and `See` was removed incorrectly while reformulating AASd-006. This commit restores it.
All constraints were cleaned up by typing exactly one space between the constraint name and its text. Furthermore, each constraint paragraph is now indented.
@s-heppner can you check this again, all asked requests are resolved. |
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0 reformulates multiple Constraints.
Reformulations that are connected to updates on Version 3.0 are listed and NOT changed yet.
I recommend to reformulate the constraints as part of the update.
Reformulations:
t.b.d. with other updates:
Constrains that have not been implemented yet and therefore have not been reformulated: