Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformulate Constraints for V3.0 #85

Merged
merged 16 commits into from
Jun 29, 2023

Conversation

dxvidnrt
Copy link
Contributor

@dxvidnrt dxvidnrt commented Jun 7, 2023

Version 3.0 reformulates multiple Constraints.
Reformulations that are connected to updates on Version 3.0 are listed and NOT changed yet.
I recommend to reformulate the constraints as part of the update.

Reformulations:

  • 6
  • 7
  • 12
  • 20
  • 109
  • 115
  • 118
  • 121
  • 122
  • 123
  • 124
  • 125
  • 126
  • 127

t.b.d. with other updates:

  • 2 (Referable/idShort)
  • 5 (AdministrativeInformation/version)
  • 77 (Extension/name)

Constrains that have not been implemented yet and therefore have not been reformulated:

  • 119
  • 120

@dxvidnrt
Copy link
Contributor Author

@s-heppner Can you review this

basyx/aas/model/base.py Outdated Show resolved Hide resolved
basyx/aas/model/base.py Outdated Show resolved Hide resolved
basyx/aas/model/base.py Outdated Show resolved Hide resolved
docs/source/constraints.rst Outdated Show resolved Hide resolved
David Niebert added 2 commits June 27, 2023 11:42
The information under `WIP` and `See` was removed incorrectly while reformulating AASd-006. This commit restores it.
All constraints were cleaned up by typing exactly one space between the constraint name and its text. Furthermore, each constraint paragraph is now indented.
@dxvidnrt
Copy link
Contributor Author

@s-heppner can you check this again, all asked requests are resolved.

@s-heppner
Copy link
Contributor

Great, thank you!

@s-heppner s-heppner merged commit 834b0aa into eclipse-basyx:improve/V30 Jun 29, 2023
@s-heppner s-heppner deleted the ConstraintsReformulated branch June 29, 2023 16:01
@s-heppner s-heppner added the v3.0 label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants